all repos — cgit @ fc4c4ba3a99f4fe4bd8a42caca902269d2e0b678

a hyperfast web frontend for git written in c 

Handle missing timestamp in commit/tag objects

When a commit or tag lacks author/committer/tagger timestamp, do not skip
the next line in the commit/tag object.

Also, do not bother to print timestamps with value 0 as it is close to certain
to be bogus.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Lars Hjemli hjemli@gmail.com
Sun, 02 Dec 2007 22:11:35 +0100
commit

fc4c4ba3a99f4fe4bd8a42caca902269d2e0b678

parent

5b75064a81f9fe8f8a446a4be050fe3dfcf52b89

2 files changed, 7 insertions(+), 3 deletions(-)

jump to
M parsing.c → parsing.c 
@@ -218,7 +218,7 @@ ret->author = substr(p, t);
 		p = t;
 		t = strchr(t, '>') + 1;
 		ret->author_email = substr(p, t);
-		ret->author_date = atol(++t);
+		ret->author_date = atol(t+1);
 		p = strchr(t, '\n') + 1;
 	}
 

@@ -229,7 +229,7 @@ ret->committer = substr(p, t);
 		p = t;
 		t = strchr(t, '>') + 1;
 		ret->committer_email = substr(p, t);
-		ret->committer_date = atol(++t);
+		ret->committer_date = atol(t+1);
 		p = strchr(t, '\n') + 1;
 	}
 

@@ -290,7 +290,7 @@ ret->tagger = substr(p, t);
 			p = t;
 			t = strchr(t, '>') + 1;
 			ret->tagger_email = substr(p, t);
-			ret->tagger_date = atol(++t);
+			ret->tagger_date = atol(t+1);
 		}
 		p = strchr(p, '\n') + 1;
 	}
M ui-shared.c → ui-shared.c 
@@ -304,6 +304,8 @@ {
 	char buf[64];
 	struct tm *time;
 
+	if (!secs)
+		return;
 	time = gmtime(&secs);
 	strftime(buf, sizeof(buf)-1, format, time);
 	html_txt(buf);

@@ -313,6 +315,8 @@ void cgit_print_age(time_t t, time_t max_relative, char *format)
 {
 	time_t now, secs;
 
+	if (!t)
+		return;
 	time(&now);
 	secs = now - t;