all repos — cgit @ fc384b16fb9787380746000d3cea2d53fccc548e

a hyperfast web frontend for git written in c 

do not infloop on a query ending in %XY, for invalid hex X or Y

When a query ends in say %gg, (or any invalid hex) e.g.,
http://git.gnome.org/browse/gdlmm/commit/?id=%gg
convert_query_hexchar calls memmove(txt, txt+3, 0), and then returns
txt-1, so the loop in http_parse_querystring never terminates.  The
solution is to make the memmove also copy the trailing NUL.
* html.c (convert_query_hexchar): Fix off-by-one error.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Jim Meyering meyering@redhat.com
Mon, 28 Feb 2011 12:18:57 +0100
commit

fc384b16fb9787380746000d3cea2d53fccc548e

parent

6bf2658f04089179aa373e47bd1d0718e808a59b

1 files changed, 1 insertions(+), 1 deletions(-)

jump to
M html.c → html.c 
@@ -249,7 +249,7 @@ }
 	d1 = hextoint(*(txt+1));
 	d2 = hextoint(*(txt+2));
 	if (d1<0 || d2<0) {
-		memmove(txt, txt+3, n-3);
+		memmove(txt, txt+3, n-2);
 		return txt-1;
 	} else {
 		*txt = d1 * 16 + d2;