all repos — cgit @ ed5dccbeaab5c8b30e1c2fe8890fa098537a2621

a hyperfast web frontend for git written in c 

ui-atom: fix resource leak: free allocation from cgit_pageurl

Coverity-id: 13945
Signed-off-by: Christian Hesse <mail@eworm.de>
Christian Hesse mail@eworm.de
Sat, 10 Oct 2015 16:56:27 +0200
commit

ed5dccbeaab5c8b30e1c2fe8890fa098537a2621

parent

144e3c6085cfea95868a799ee976ed221dd86d8a

1 files changed, 4 insertions(+), 1 deletions(-)

jump to
M ui-atom.c → ui-atom.c 
@@ -53,14 +53,17 @@ html("<published>");
 	cgit_print_date(info->author_date, FMT_ATOMDATE, 0);
 	html("</published>\n");
 	if (host) {
+		char *pageurl;
 		html("<link rel='alternate' type='text/html' href='");
 		html(cgit_httpscheme());
 		html_attr(host);
-		html_attr(cgit_pageurl(ctx.repo->url, "commit", NULL));
+		pageurl = cgit_pageurl(ctx.repo->url, "commit", NULL);
+		html_attr(pageurl);
 		if (ctx.cfg.virtual_root)
 			delim = '?';
 		htmlf("%cid=%s", delim, hex);
 		html("'/>\n");
+		free(pageurl);
 	}
 	htmlf("<id>%s</id>\n", hex);
 	html("<content type='text'>\n");