all repos — cgit @ dc1a8eadd4c063fe6782fa99f9db41c46b85d048

a hyperfast web frontend for git written in c 

shared.c: do not modify const memory

Noticed-by: zhongjj <zhongjj@lemote.com>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Lars Hjemli hjemli@gmail.com
Sun, 22 May 2011 12:45:32 +0200
commit

dc1a8eadd4c063fe6782fa99f9db41c46b85d048

parent

084ca50972b4be120eba8d22ce585766ae315c36

1 files changed, 3 insertions(+), 11 deletions(-)

jump to
M shared.c → shared.c 
@@ -100,23 +100,15 @@
 char *trim_end(const char *str, char c)
 {
 	int len;
-	char *s, *t;
 
 	if (str == NULL)
 		return NULL;
-	t = (char *)str;
-	len = strlen(t);
-	while(len > 0 && t[len - 1] == c)
+	len = strlen(str);
+	while(len > 0 && str[len - 1] == c)
 		len--;
-
 	if (len == 0)
 		return NULL;
-
-	c = t[len];
-	t[len] = '\0';
-	s = xstrdup(t);
-	t[len] = c;
-	return s;
+	return xstrndup(str, len);
 }
 
 char *strlpart(char *txt, int maxlen)