ui-log.c: do not link from age column The link url wasn't properly escaped, and since the link was identical to the one used on the commit message it didn't serve any special purpose. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Lars Hjemli hjemli@gmail.com
Thu, 02 Jun 2011 10:30:26 +0000
2 files changed,
1 insertions(+),
10 deletions(-)
M
tests/t0103-log.sh
→
tests/t0103-log.sh
@@ -18,7 +18,7 @@ '
run_test 'find commit 1' 'grep -e "commit 1" trash/tmp' run_test 'find link with %20 in path' 'grep -e "/with%20space/log/?qt=grep" trash/tmp' run_test 'find link with + in arg' 'grep -e "/log/?qt=grep&q=commit+1" trash/tmp' -run_test BUG 'no links with space in path' '! grep -e "href=./with space/" trash/tmp' +run_test 'no links with space in path' '! grep -e "href=./with space/" trash/tmp' run_test 'no links with space in arg' '! grep -e "q=commit 1" trash/tmp' run_test 'commit 2 is not visible' '! grep -e "commit 2" trash/tmp'
M
ui-log.c
→
ui-log.c
@@ -95,7 +95,6 @@
void print_commit(struct commit *commit, struct rev_info *revs) { struct commitinfo *info; - char *tmp; int cols = revs->graph ? 3 : 2; struct strbuf graphbuf = STRBUF_INIT; struct strbuf msgbuf = STRBUF_INIT;@@ -130,11 +129,7 @@ strbuf_setlen(&graphbuf, 0);
} else { html("<td>"); - tmp = fmt("id=%s", sha1_to_hex(commit->object.sha1)); - tmp = cgit_fileurl(ctx.repo->url, "commit", ctx.qry.vpath, tmp); - html_link_open(tmp, NULL, NULL); cgit_print_age(commit->date, TM_WEEK * 2, FMT_SHORTDATE); - html_link_close(); html("</td>"); }@@ -172,11 +167,7 @@ html_txt(info->author);
if (revs->graph) { html("</td><td>"); - tmp = fmt("id=%s", sha1_to_hex(commit->object.sha1)); - tmp = cgit_fileurl(ctx.repo->url, "commit", ctx.qry.vpath, tmp); - html_link_open(tmp, NULL, NULL); cgit_print_age(commit->date, TM_WEEK * 2, FMT_SHORTDATE); - html_link_close(); } if (ctx.repo->enable_log_filecount) {