Do not alter incoming sha1 when handling the download refs. The code used to overwrite the const sha1 parameter just to avoid declaring an extra variable. Fix it. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Lars Hjemli hjemli@gmail.com
Tue, 15 May 2007 01:05:39 +0200
1 files changed,
5 insertions(+),
2 deletions(-)
jump to
M
ui-summary.c
→
ui-summary.c
@@ -130,6 +130,7 @@ struct tag *tag;
struct taginfo *info; struct object *obj; char buf[256], *url; + unsigned char fileid[20]; if (prefixcmp(refname, "refs/archives")) return 0;@@ -141,9 +142,11 @@ if (obj->type == OBJ_TAG) {
tag = lookup_tag(sha1); if (!tag || parse_tag(tag) || !(info = cgit_parse_tag(tag))) return 0; - hashcpy(sha1, tag->tagged->sha1); + hashcpy(fileid, tag->tagged->sha1); } else if (obj->type != OBJ_BLOB) { return 0; + } else { + hashcpy(fileid, sha1); } if (!header) { html("<table>");@@ -152,7 +155,7 @@ header = 1;
} html("<tr><td>"); url = cgit_pageurl(cgit_query_repo, "blob", - fmt("id=%s&path=%s", sha1_to_hex(sha1), + fmt("id=%s&path=%s", sha1_to_hex(fileid), buf)); html_link_open(url, NULL, NULL); html_txt(buf);