all repos — cgit @ caca860ba79fe9f6bc387f64ddb57ac0db1fac33

a hyperfast web frontend for git written in c

ui-refs.c: Remove global header variable

print_tag_header() is only called from cgit_print_tags() -- the
conditional invocation in print_tag() is never executed since
print_tag() is only called by cgit_print_tags() which already executes
print_tag_header() before (resulting in the global variable being always
set in when the condition is evaluated).

Remove the global variable and the conditional invocation.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
Lukas Fleischer cgit@cryptocrack.de
Sat, 06 Apr 2013 23:39:07 +0200
commit

caca860ba79fe9f6bc387f64ddb57ac0db1fac33

parent

3edfd83db61f5dd2f046e6e8c21dfceeae03ed82

1 files changed, 0 insertions(+), 6 deletions(-)

jump to
M ui-refs.cui-refs.c

@@ -11,8 +11,6 @@ #include "ui-refs.h"

#include "html.h" #include "ui-shared.h" -static int header; - static int cmp_age(int age1, int age2) { if (age1 != 0 && age2 != 0)

@@ -96,7 +94,6 @@ html("<tr class='nohover'><th class='left'>Tag</th>"

"<th class='left'>Download</th>" "<th class='left'>Author</th>" "<th class='left' colspan='2'>Age</th></tr>\n"); - header = 1; } static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)

@@ -156,8 +153,6 @@ if (info->tagger_date > 0)

cgit_print_age(info->tagger_date, -1, NULL); html("</td></tr>\n"); } else { - if (!header) - print_tag_header(); html("<tr><td>"); cgit_tag_link(name, NULL, NULL, ctx.qry.head, name); html("</td><td>");

@@ -221,7 +216,6 @@ {

struct reflist list; int i; - header = 0; list.refs = NULL; list.alloc = list.count = 0; for_each_tag_ref(cgit_refs_cb, &list);