all repos — cgit @ c8ea73caabcb16ffb74baa70d35650027ed772c4

a hyperfast web frontend for git written in c

ui-repolist.c: do not return random/stale data from read_agefile

When git/date.c:parse_date() cannot parse its input it returns -1. But
read_agefile() checks if the result is different from zero, essentialy
returning random data from the date buffer when parsing fails. This
patch fixes the issue by verifying that the result from parse_date()
is positive.

Noticed-by: Julius Plenz <plenz@cis.fu-berlin.de>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Lars Hjemli hjemli@gmail.com
Mon, 23 May 2011 23:10:37 +0200
commit

c8ea73caabcb16ffb74baa70d35650027ed772c4

parent

9afc883297b0d0943e9b358d2299950f33e8e5ed

1 files changed, 1 insertions(+), 1 deletions(-)

jump to
M ui-repolist.cui-repolist.c

@@ -20,7 +20,7 @@

if (readfile(path, &buf, &size)) return -1; - if (parse_date(buf, buf2, sizeof(buf2))) + if (parse_date(buf, buf2, sizeof(buf2)) > 0) result = strtoul(buf2, NULL, 10); else result = 0;