all repos — cgit @ b28b105ec172b258ae5d629381a5890697c2f938

a hyperfast web frontend for git written in c

Enable default value for head parameter

Pages which expect head to be specified in the querystring can now be
given a default value, configurable per repository (via repo.defbranch,
which defaults to "master").

Currently, only the log page actually works without parameters, but the
defbranch is bound to be exploited.

This also removes some dead code from shared.c

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Lars Hjemli hjemli@gmail.com
Wed, 16 May 2007 00:14:51 +0200
commit

b28b105ec172b258ae5d629381a5890697c2f938

parent

47a81c77fdd017227632c4df9a0b7b135b8a738d

3 files changed, 7 insertions(+), 14 deletions(-)

jump to
M cgit.ccgit.c

@@ -65,6 +65,9 @@ {

char *title; int show_search; + if (!cgit_query_head) + cgit_query_head = cgit_repo->defbranch; + if (chdir(cgit_repo->path)) { title = fmt("%s - %s", cgit_root_title, "Bad request"); cgit_print_docstart(title, item);
M cgit.hcgit.h

@@ -35,6 +35,7 @@ char *name;

char *path; char *desc; char *owner; + char *defbranch; char *module_link; int snapshots; };
M shared.cshared.c

@@ -32,10 +32,6 @@

int cgit_max_msg_len = 60; int cgit_max_commit_count = 50; -char *cgit_repo_name = NULL; -char *cgit_repo_desc = NULL; -char *cgit_repo_owner = NULL; - int cgit_query_has_symref = 0; int cgit_query_has_sha1 = 0;

@@ -86,6 +82,7 @@ ret->name = ret->url;

ret->path = NULL; ret->desc = NULL; ret->owner = NULL; + ret->defbranch = "master"; ret->snapshots = cgit_snapshots; ret->module_link = cgit_module_link; return ret;

@@ -133,22 +130,14 @@ else if (cgit_repo && !strcmp(name, "repo.desc"))

cgit_repo->desc = xstrdup(value); else if (cgit_repo && !strcmp(name, "repo.owner")) cgit_repo->owner = xstrdup(value); + else if (cgit_repo && !strcmp(name, "repo.defbranch")) + cgit_repo->defbranch = xstrdup(value); else if (cgit_repo && !strcmp(name, "repo.snapshots")) cgit_repo->snapshots = atoi(value); else if (cgit_repo && !strcmp(name, "repo.module-link")) cgit_repo->module_link= xstrdup(value); else if (!strcmp(name, "include")) cgit_read_config(value, cgit_global_config_cb); -} - -void cgit_repo_config_cb(const char *name, const char *value) -{ - if (!strcmp(name, "name")) - cgit_repo_name = xstrdup(value); - else if (!strcmp(name, "desc")) - cgit_repo_desc = xstrdup(value); - else if (!strcmp(name, "owner")) - cgit_repo_owner = xstrdup(value); } void cgit_querystring_cb(const char *name, const char *value)