all repos — cgit @ aae067197f3fff253800359649d1f10014b23ecd

a hyperfast web frontend for git written in c

Return 404 on command not found

We were returning 200 before. Even 404 is questionable in all cases, but
200 was totally wrong. Also match the case of all of the "Not found"
status messsages.

Signed-off-by: Dan McGee <dpmcgee@gmail.com>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Dan McGee dpmcgee@gmail.com
Wed, 12 Jan 2011 12:06:08 -0600
commit

aae067197f3fff253800359649d1f10014b23ecd

parent

42231328d3fa1e443566a5d8e6c3ccbce16157b6

1 files changed, 3 insertions(+), 1 deletions(-)

jump to
M cgit.ccgit.c

@@ -429,7 +429,7 @@ if (get_sha1(ctx->qry.head, sha1)) {

tmp = xstrdup(ctx->qry.head); ctx->qry.head = ctx->repo->defbranch; ctx->page.status = 404; - ctx->page.statusmsg = "not found"; + ctx->page.statusmsg = "Not found"; cgit_print_http_headers(ctx); cgit_print_docstart(ctx); cgit_print_pageheader(ctx);

@@ -448,6 +448,8 @@

cmd = cgit_get_cmd(ctx); if (!cmd) { ctx->page.title = "cgit error"; + ctx->page.status = 404; + ctx->page.statusmsg = "Not found"; cgit_print_http_headers(ctx); cgit_print_docstart(ctx); cgit_print_pageheader(ctx);