all repos — cgit @ 94b7c76e531315b245f79a9e2dfd0655e6e45fee

a hyperfast web frontend for git written in c 

Fix segmentation fault in empty repository

When a repository is empty, the ATOM feed link is written in the header,
but this involves formatting ctx->qry.head which is NULL in this case.
With glibc, vsnprintf formats "%s" with a NULL input as "(null)" but on
Solaris this results in a segmentation fault.  Since we don't have a
meaningful head for the atom feed in an empty repository, it's simplest
not to write out the link element at all.

Signed-off-by: John Keeping <john@metanate.com>
John Keeping john@metanate.com
Thu, 24 Nov 2011 11:54:47 +0000
commit

94b7c76e531315b245f79a9e2dfd0655e6e45fee

parent

fbd254d54e28e002a0d56b81c192156599df1e6b

1 files changed, 1 insertions(+), 1 deletions(-)

jump to
M ui-shared.c → ui-shared.c 
@@ -619,7 +619,7 @@ html("<link rel='shortcut icon' href='");
 		html_attr(ctx->cfg.favicon);
 		html("'/>\n");
 	}
-	if (host && ctx->repo) {
+	if (host && ctx->repo && ctx->qry.head) {
 		html("<link rel='alternate' title='Atom feed' href='");
 		html(cgit_httpscheme());
 		html_attr(cgit_hosturl());