all repos — cgit @ 8d946079c5f51ce934ff5edf6333962c6061d8a5

a hyperfast web frontend for git written in c 

ui-shared.c: fix segfault when repo is empty

PATH_INFO="/$REPONAME/commit/?id=1" QUERY_STRING="id=1" ./cgit.cgi
triggers segfault when the repository is empty and therefore
ctx.qry.head is unset

Signed-off-by: Florian Pritz <bluewind@xssn.at>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Florian Pritz bluewind@xssn.at
Mon, 01 Feb 2010 17:55:37 +0100
commit

8d946079c5f51ce934ff5edf6333962c6061d8a5

parent

c86e206a9773f97dc6de6bbf45712bb304de3653

1 files changed, 2 insertions(+), 2 deletions(-)

jump to
M ui-shared.c → ui-shared.c 
@@ -246,7 +246,7 @@ {
 	char *delim;
 
 	delim = repolink(title, class, page, head, path);
-	if (rev && strcmp(rev, ctx.qry.head)) {
+	if (rev && ctx.qry.head != NULL && strcmp(rev, ctx.qry.head)) {
 		html(delim);
 		html("id=");
 		html_url_arg(rev);

@@ -346,7 +346,7 @@ {
 	char *delim;
 
 	delim = repolink(title, class, "diff", head, path);
-	if (new_rev && strcmp(new_rev, ctx.qry.head)) {
+	if (new_rev && ctx.qry.head != NULL && strcmp(new_rev, ctx.qry.head)) {
 		html(delim);
 		html("id=");
 		html_url_arg(new_rev);