all repos — cgit @ 8cfe4897f01066ae901bdd6ef106faf8e8f2ddf2

a hyperfast web frontend for git written in c 

Close fd on error in readfile()

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Rys Sommefeldt rys@pixeltards.com
Sat, 07 Nov 2009 15:24:45 +0100
commit

8cfe4897f01066ae901bdd6ef106faf8e8f2ddf2

parent

e34a3b5adc00255f8acb7d674e5fdadef2ac80f7

1 files changed, 7 insertions(+), 2 deletions(-)

jump to
M shared.c → shared.c 
@@ -406,12 +406,17 @@
 	fd = open(path, O_RDONLY);
 	if (fd == -1)
 		return errno;
-	if (fstat(fd, &st))
+	if (fstat(fd, &st)) {
+		close(fd);
 		return errno;
-	if (!S_ISREG(st.st_mode))
+	}
+	if (!S_ISREG(st.st_mode)) {
+		close(fd);
 		return EISDIR;
+	}
 	*buf = xmalloc(st.st_size + 1);
 	*size = read_in_full(fd, *buf, st.st_size);
 	(*buf)[*size] = '\0';
+	close(fd);
 	return (*size == st.st_size ? 0 : errno);
 }