all repos — cgit @ 8a631b1173b1abecc5a737b0e21751ddbabf9df2

a hyperfast web frontend for git written in c 

ui-tag.c: do not segfault when id is missing from query-string

The purpose of the tag page is to print info about a specific tag,
but if no tag was specified on the query-string cgit used to segfault.

With this patch, cgit will fallback to the value of the 'h' parameter
instead (which is never NULL due to prepare_repo_cmd() in cgit.c).

It will now also verify that the specified tagname is in fact a valid
ref in the 'refs/tags/' namespace, i.e. specifying 'id=master' will
trigger a 'Bad tag reference' error.

Noticed-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Lars Hjemli hjemli@gmail.com
Mon, 17 Aug 2009 09:19:05 +0200
commit

8a631b1173b1abecc5a737b0e21751ddbabf9df2

parent

fdd559abd6e6ec5e522dc5496b2bcabd36d6ba9d

1 files changed, 4 insertions(+), 1 deletions(-)

jump to
M ui-tag.c → ui-tag.c 
@@ -37,7 +37,10 @@ struct object *obj;
 	struct tag *tag;
 	struct taginfo *info;
 
-	if (get_sha1(revname, sha1)) {
+	if (!revname)
+		revname = ctx.qry.head;
+
+	if (get_sha1(fmt("refs/tags/%s", revname), sha1)) {
 		cgit_print_error(fmt("Bad tag reference: %s", revname));
 		return;
 	}