all repos — cgit @ 7e1c0ed2aa50ed2290f63912897a3724b224b7ea

a hyperfast web frontend for git written in c 

diffstat: do not rely on uninitialized data

Right now if you visit:
<http://git.zx2c4.com/systemd/diff/src/udev/udev-builtin-input_id.c?id=bcfce235>
you'll see that if you reload the page a few times, a bunch of times the
diffstat comes out with no lines being shown or changed. I'm not
currently sure what the cause of this is, but I suspect it might have to
do with this uninitialized data.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Jason A. Donenfeld Jason@zx2c4.com
Thu, 20 Feb 2014 19:48:24 +0100
commit

7e1c0ed2aa50ed2290f63912897a3724b224b7ea

parent

e8cacb5981039e7e74921659ea50e287395ed411

1 files changed, 1 insertions(+), 0 deletions(-)

jump to
M shared.c → shared.c 
@@ -368,6 +368,7 @@ {
 	struct diff_options opt;
 	struct pathspec_item item;
 
+	memset(&item, 0, sizeof(item));
 	diff_setup(&opt);
 	opt.output_format = DIFF_FORMAT_CALLBACK;
 	opt.detect_rename = 1;