all repos — cgit @ 74ebf82229829bbdbe74a4d9a7b6f29d2889dfc8

a hyperfast web frontend for git written in c 

ui-plain: more efficient walk_tree()

Git's read_tree_recursive() already filters out the objects by pathname,
so we only have to compare baselen to the expected.  That is, no string
matching is required.

Additionally, if the requested path is a directory, the old code would
walk through all of its immediate children.  This is not necessary, this
so we no longer do that.

Signed-off-by: Mark Lodato <lodatom@gmail.com>
Mark Lodato lodatom@gmail.com
Sun, 31 Jan 2010 01:07:41 -0500
commit

74ebf82229829bbdbe74a4d9a7b6f29d2889dfc8

parent

89082346d50ec283a16d3127677f30b427781b6a

1 files changed, 14 insertions(+), 6 deletions(-)

jump to
M ui-plain.c → ui-plain.c 
@@ -10,7 +10,7 @@ #include "cgit.h"
 #include "html.h"
 #include "ui-shared.h"
 
-char *match_path;
+int match_baselen;
 int match;
 
 static void print_object(const unsigned char *sha1, const char *path)

@@ -56,13 +56,21 @@ static int walk_tree(const unsigned char *sha1, const char *base, int baselen,
 		     const char *pathname, unsigned mode, int stage,
 		     void *cbdata)
 {
-	if (S_ISDIR(mode))
+	if (baselen == match_baselen) {
+		if (S_ISREG(mode))
+			print_object(sha1, pathname);
+	}
+	else if (S_ISDIR(mode))
 		return READ_TREE_RECURSIVE;
 
-	if (S_ISREG(mode) && !strncmp(base, match_path, baselen) &&
-	    !strcmp(pathname, match_path + baselen))
-		print_object(sha1, pathname);
+	return 0;
+}
 
+static int basedir_len(const char *path)
+{
+	char *p = strrchr(path, '/');
+	if (p)
+		return p - path + 1;
 	return 0;
 }
 

@@ -85,7 +93,7 @@ if (!commit || parse_commit(commit)) {
 		html_status(404, "Not found", 0);
 		return;
 	}
-	match_path = ctx->qry.path;
+	match_baselen = basedir_len(paths[0]);
 	read_tree_recursive(commit->tree, "", 0, 0, paths, walk_tree, NULL);
 	if (!match)
 		html_status(404, "Not found", 0);