all repos — cgit @ 6fddad7251021b307c8a3f70fdd2aa04c3f74eaa

a hyperfast web frontend for git written in c

ui-snapshot: avoid segfault when no filename is specified

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Lars Hjemli hjemli@gmail.com
Sun, 15 Mar 2009 08:57:33 +0100
commit

6fddad7251021b307c8a3f70fdd2aa04c3f74eaa

parent

112973615a78ce61fd6e767128df03b075be72ca

1 files changed, 17 insertions(+), 6 deletions(-)

jump to
M ui-snapshot.cui-snapshot.c

@@ -156,20 +156,31 @@

return NULL; } +void show_error(char *msg) +{ + ctx.page.mimetype = "text/html"; + cgit_print_http_headers(&ctx); + cgit_print_docstart(&ctx); + cgit_print_pageheader(&ctx); + cgit_print_error(msg); + cgit_print_docend(); +} + void cgit_print_snapshot(const char *head, const char *hex, const char *filename, int snapshots, int dwim) { const struct cgit_snapshot_format* f; char *prefix = NULL; + if (!filename) { + show_error("No snapshot name specified"); + return; + } + f = get_format(filename); if (!f) { - ctx.page.mimetype = "text/html"; - cgit_print_http_headers(&ctx); - cgit_print_docstart(&ctx); - cgit_print_pageheader(&ctx); - cgit_print_error(fmt("Unsupported snapshot format: %s", filename)); - cgit_print_docend(); + show_error(xstrdup(fmt("Unsupported snapshot format: %s", + filename))); return; }