all repos — cgit @ 68de710c1c0e9b823a156b1398643601a682fbf9

a hyperfast web frontend for git written in c

ui-ssdiff: ban strncat()

Git version v2.21.0 marks strncat() as banned (commit
ace5707a803eda0f1dde3d776dc3729d3bc7759a), so replace it.

Signed-off-by: Christian Hesse <mail@eworm.de>
Christian Hesse mail@eworm.de
Tue, 12 Feb 2019 21:53:02 +0100
commit

68de710c1c0e9b823a156b1398643601a682fbf9

parent

ccba7eb9d0c43ffe99178ab6632dc3794f887309

1 files changed, 5 insertions(+), 3 deletions(-)

jump to
M ui-ssdiff.cui-ssdiff.c

@@ -117,7 +117,7 @@ size_t linelen = strlen(line);

int n_tabs = 0; int i; char *result; - int result_len; + size_t result_len; if (linelen == 0) { result = xmalloc(1);

@@ -136,10 +136,12 @@

for (;;) { cur_buf = strchr(prev_buf, '\t'); if (!cur_buf) { - strncat(result, prev_buf, result_len); + linelen = strlen(result); + strlcpy(&result[linelen], prev_buf, result_len - linelen + 1); break; } else { - strncat(result, prev_buf, cur_buf - prev_buf); + linelen = strlen(result); + strlcpy(&result[linelen], prev_buf, cur_buf - prev_buf + 1); linelen = strlen(result); memset(&result[linelen], ' ', 8 - (linelen % 8)); result[linelen + 8 - (linelen % 8)] = '\0';