all repos — cgit @ 52e605caf573fa20fdd4fbac5e1cc69b7740b1f5

a hyperfast web frontend for git written in c

Handle %xx encoding in querystring

Convert valid %xx expressions in querystring to ascii, ignore invalid
expressions (i.e. eat the three characters %xx).

Signed-off-by: Lars Hjemli <larsh@hal-2004.(none)>
Lars Hjemli larsh@hal-2004.(none)
Thu, 04 Jan 2007 16:53:03 +0100
commit

52e605caf573fa20fdd4fbac5e1cc69b7740b1f5

parent

05b13194b4b40a2614692125d5037ef20c5fb20e

3 files changed, 36 insertions(+), 0 deletions(-)

jump to
M cgit.hcgit.h

@@ -67,6 +67,8 @@ extern void cgit_global_config_cb(const char *name, const char *value);

extern void cgit_repo_config_cb(const char *name, const char *value); extern void cgit_querystring_cb(const char *name, const char *value); +extern int hextoint(char c); + extern void *cgit_free_commitinfo(struct commitinfo *info); extern char *fmt(const char *format,...);
M parsing.cparsing.c

@@ -79,6 +79,25 @@ fclose(f);

return ret; } +char *convert_query_hexchar(char *txt) +{ + int d1, d2; + if (strlen(txt) < 3) { + *txt = '\0'; + return txt-1; + } + d1 = hextoint(*(txt+1)); + d2 = hextoint(*(txt+2)); + if (d1<0 || d2<0) { + strcpy(txt, txt+3); + return txt-1; + } else { + *txt = d1 * 16 + d2; + strcpy(txt+1, txt+3); + return txt; + } +} + int cgit_parse_query(char *txt, configfn fn) { char *t, *value = NULL, c;

@@ -94,6 +113,8 @@ *t = '\0';

value = t+1; } else if (c=='+') { *t = ' '; + } else if (c=='%') { + t = convert_query_hexchar(t); } else if (c=='&') { *t = '\0'; (*fn)(txt, value);
M shared.cshared.c

@@ -113,3 +113,16 @@ free(info->subject);

free(info); return NULL; } + +int hextoint(char c) +{ + if (c >= 'a' && c <= 'f') + return 10 + c - 'a'; + else if (c >= 'A' && c <= 'F') + return 10 + c - 'A'; + else if (c >= '0' && c <= '9') + return c - '0'; + else + return -1; +} +