all repos — cgit @ 481ce5e298e2dcd7edc1d4a30e523dda2ce58b01

a hyperfast web frontend for git written in c 

shared.c: avoid SEGFAULT when checking for binary buffers

Before calling buffer_is_binary() we need to verify that the buffer
is valid.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Lars Hjemli hjemli@gmail.com
Sun, 01 Feb 2009 19:29:24 +0100
commit

481ce5e298e2dcd7edc1d4a30e523dda2ce58b01

parent

ae1d4d75b2a2eb3534ff4b3685cc5c0b80007ef7

1 files changed, 2 insertions(+), 2 deletions(-)

jump to
M shared.c → shared.c 
@@ -271,8 +271,8 @@
 	*old_size = file1.size;
 	*new_size = file2.size;
 
-	if (buffer_is_binary(file1.ptr, file1.size) ||
-	    buffer_is_binary(file2.ptr, file2.size)) {
+	if ((file1.ptr && buffer_is_binary(file1.ptr, file1.size)) ||
+	    (file2.ptr && buffer_is_binary(file2.ptr, file2.size))) {
 		*binary = 1;
 		return 0;
 	}