all repos — cgit @ 3ce6fc16ef4670c535c6e35d48c7f980ff8a5532

a hyperfast web frontend for git written in c

Handle single-line and empty commit subjects

If commit object ends with \0 after subject line, then info->subject
was not set.

This commit fixes this and also sets subject to ** empty ** if it
would otherwise be empty, so that there is something to click on.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Ondrej Jirman ondrej.jirman@zonio.net
Sat, 26 May 2007 02:19:38 +0200
commit

3ce6fc16ef4670c535c6e35d48c7f980ff8a5532

parent

1a63cfcc3d83919e790e7e279eb35fc75adb0e3c

1 files changed, 8 insertions(+), 3 deletions(-)

jump to
M parsing.cparsing.c

@@ -234,14 +234,19 @@ while (*p == '\n')

p = strchr(p, '\n') + 1; t = strchr(p, '\n'); - if (t && *t) { - ret->subject = substr(p, t); + if (t) { + if (*t == '\0') + ret->subject = strdup("** empty **"); + else + ret->subject = substr(p, t); p = t + 1; while (*p == '\n') p = strchr(p, '\n') + 1; ret->msg = p; - } + } else + ret->subject = substr(p, p+strlen(p)); + return ret; }