all repos — cgit @ 2abce4300b90fa80845193c14d4b6849720007b1

a hyperfast web frontend for git written in c

Disallow use of undocumented snapshot delimiters

Since the introduction of selective snapshot format configuration in
dc3c9b5 (allow selective enabling of snapshots, 2007-07-21), we allowed
seven different delimiters for snapshot formats, while the documentation
has always been clear about spaces being the only valid delimiter:

    The value is a space-separated list of zero or more of the values
    "tar", "tar.gz", "tar.bz2", "tar.xz" and "zip".

Supporting the undocumented delimiters makes the code unnecessarily
complex. Remove them.

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
Lukas Fleischer cgit@cryptocrack.de
Fri, 10 Jan 2014 12:44:36 +0100
commit

2abce4300b90fa80845193c14d4b6849720007b1

parent

36bdb2171f7154fcdf1a24d38c8ce3bd7e448cb1

1 files changed, 1 insertions(+), 1 deletions(-)

jump to
M shared.cshared.c

@@ -405,7 +405,7 @@

int cgit_parse_snapshots_mask(const char *str) { const struct cgit_snapshot_format *f; - static const char *delim = " \t,:/|;"; + static const char *delim = " "; int tl, sl, rv = 0; /* favor legacy setting */