all repos — cgit @ 1e9f1ee64e5f8f75a361260a2165996bc137b961

a hyperfast web frontend for git written in c 

shared.c: use die_errno() where appropriate

This replaces some code that is re-implementing die_errno by just
calling the function.

Signed-off-by: John Keeping <john@keeping.me.uk>
John Keeping john@keeping.me.uk
Sat, 18 May 2013 16:21:36 +0100
commit

1e9f1ee64e5f8f75a361260a2165996bc137b961

parent

1fec7cd6f817e52a6e55458d584a7a5092ba6aed

1 files changed, 4 insertions(+), 5 deletions(-)

jump to
M shared.c → shared.c 
@@ -15,21 +15,21 @@
 int chk_zero(int result, char *msg)
 {
 	if (result != 0)
-		die("%s: %s", msg, strerror(errno));
+		die_errno("%s", msg);
 	return result;
 }
 
 int chk_positive(int result, char *msg)
 {
 	if (result <= 0)
-		die("%s: %s", msg, strerror(errno));
+		die_errno("%s", msg);
 	return result;
 }
 
 int chk_non_negative(int result, char *msg)
 {
 	if (result < 0)
-		die("%s: %s", msg, strerror(errno));
+		die_errno("%s", msg);
 	return result;
 }
 

@@ -468,8 +468,7 @@ close(filter->pipe_fh[1]);
 		chk_non_negative(dup2(filter->pipe_fh[0], STDIN_FILENO),
 			"Unable to use pipe as STDIN");
 		execvp(filter->cmd, filter->argv);
-		die("Unable to exec subprocess %s: %s (%d)", filter->cmd,
-			strerror(errno), errno);
+		die_errno("Unable to exec subprocess %s", filter->cmd);
 	}
 	close(filter->pipe_fh[0]);
 	chk_non_negative(dup2(filter->pipe_fh[1], STDOUT_FILENO),