all repos — cgit @ 1c32e008c8fda46f812c38f46ae7515bcf8002ee

a hyperfast web frontend for git written in c 

ui-blob: don't segfault when no path is given

It it possible to inspect blobs by specifying only the SHA-1, and CGit
provides links to do so, for example if a tag points directly at a blob.
In this case the path_items structure is never used, but creating it
still causes strlen to be run on a null pointer.  Fix this.

This error was introduced by commit c1633c6 (Update git to v1.7.6.5 -
2013-03-02).

Signed-off-by: John Keeping <john@keeping.me.uk>
John Keeping john@keeping.me.uk
Sun, 07 Apr 2013 15:06:23 +0100
commit

1c32e008c8fda46f812c38f46ae7515bcf8002ee

parent

b60e6bff75719a5fb0df970bac3be6b2726cf73a

1 files changed, 1 insertions(+), 1 deletions(-)

jump to
M ui-blob.c → ui-blob.c 
@@ -80,7 +80,7 @@ unsigned long size;
 	struct commit *commit;
 	struct pathspec_item path_items = {
 		.match = path,
-		.len = strlen(path)
+		.len = path ? strlen(path) : 0
 	};
 	struct pathspec paths = {
 		.nr = 1,