all repos — cgit @ 1b4ef6783a71962f8b5da3a23f2830f0f0f55ea0

a hyperfast web frontend for git written in c 

ui-shared: don't print path crumbs without a repo

cgit_print_path_crumbs() can call repolink() which assumes that ctx.repo
is non-null.  Currently we don't have any commands that set want_vpath
without also setting want_repo so it shouldn't be possible to fail this
test, but the check in cgit.c is in the wrong order so it is possible to
specify a query string like "?p=log&path=foo/bar" to end up here without
a valid repository.

This was found by American fuzzy lop [0].

[0] http://lcamtuf.coredump.cx/afl/

Signed-off-by: John Keeping <john@keeping.me.uk>
John Keeping john@keeping.me.uk
Sun, 19 Feb 2017 12:27:48 +0000
commit

1b4ef6783a71962f8b5da3a23f2830f0f0f55ea0

parent

6d3c8bc37f6124c2193d66587079975d381aa435

1 files changed, 1 insertions(+), 1 deletions(-)

jump to
M ui-shared.c → ui-shared.c 
@@ -1039,7 +1039,7 @@ html("</form>");
 		free(currenturl);
 	}
 	html("</td></tr></table>\n");
-	if (ctx.env.authenticated && ctx.qry.vpath) {
+	if (ctx.env.authenticated && ctx.repo && ctx.qry.vpath) {
 		html("<div class='path'>");
 		html("path: ");
 		cgit_print_path_crumbs(ctx.qry.vpath);